fix(cmdline): check cursor position to avoid hang on exit #936
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm experiencing this issue too. My |
Does this happen with my patch or with the vanilla plugin ? |
folke
pushed a commit
that referenced
this pull request
Sep 18, 2024
🤖 I have created a release *beep* *boop* --- ## [4.5.1](v4.5.0...v4.5.1) (2024-09-18) ### Bug Fixes * dont redraw when exiting. Fixes [#936](#936). Fixes [#921](#921) ([8c6a024](8c6a024)) * **hacks:** dont close timer multiple times during exit ([86a4891](86a4891)) * **hacks:** only redraw cursor when cmdline is active. Fixes [#950](#950). Fixes [#937](#937). Fixes [#923](#923) ([3373ab5](3373ab5)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
since this commit, sometime when you exit neovim, it hangs for a second with a visual glitch then it exits:
video example
Just before neovim exits you get this error message:
So i added some checks to the
cursorvariable in thefix_cursor()function insidelua/noice/ui/cmdline.luato check if the cursor was out of bounds and this seems to fix the issueRelated Issue(s)